[
https://issues.apache.org/jira/browse/DBUTILS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773658#action_12773658
]
eugen p. commented on DBUTILS-54:
---------------------------------
@Julien, thanks for submission
@Dan, I agree that blowing API is worse than writing 5 more lines in the code -
yet, the most valueable at dbUtils is not the fillStatement() method, rather it
seems to be the fact of auto-releasing of resources ( the annoying close()
invocation :)
However, I would provide a slightly different solution - two more classes
derived from base. Please find in file attachments. Sample usage would look
{code}
GenKeyQueryRunner runner = new GenKeyQueryRunner(new GeneratedKeysHandler()
{
public String [] getKeyColName() {
return new String[]{"personID"};
}
public void handle(ResultSet rs) throws SQLException {
System.out.println("generated key " + rs.getInt(1));
}
});
runner.update(someConnection, "INSERT INTO FOO(NAME) VALUES ('BAR')");
{code}
This would keep up backwards compabitility. Of course the update() method also
might be able to return the resulting object, like query() does with
ResultSetHandler, but this would end up in incompatible APIs and yet another
QueryRunner derivate.
> Generated key handling for updates
> ----------------------------------
>
> Key: DBUTILS-54
> URL: https://issues.apache.org/jira/browse/DBUTILS-54
> Project: Commons DbUtils
> Issue Type: Improvement
> Affects Versions: 1.2, Nightly Builds
> Reporter: Michael V
> Priority: Minor
> Attachments: QueryRunner.patch
>
>
> It would be great (and fairly easy to do) to provide a way to get
> autogenerated keys from QueryRunner.update. There was an email thread about
> this in 2004 but it seems it never was actually implemented.
> http://mail-archives.apache.org/mod_mbox/commons-dev/200406.mbox/%[email protected]%3e
> The thought is to provide an ability to recover generated keys, for instance
> by providing a result set handler, in which case prepared statement would be
> generated with RETURN_GENERATED_KEYS and getGeneratedKeys() would be passed
> to the result handler.
> It seems that in 1.2 there is a way to get PreparedStatement and work with
> QueryRunner more as a support to JDBC but IMO it would be cool to add this
> feature.
> example solution:
> {noformat}
> public int update(Connection conn, String sql, Object... params)
> throws SQLException {
> update(sql, null, params);
> }
> protected PreparedStatement prepareStatement(Connection conn, String sql,
> int autoGeneratedKeys)
> throws SQLException {
> return conn.prepareStatement(sql, autoGeneratedKeys);
> }
> public int update(Connection conn, String sql, ResultSetHandler<?> rsh,
> Object... params)
> throws SQLException {
> PreparedStatement stmt = null;
> int rows = 0;
> try {
> stmt = this.prepareStatement(conn, sql,
> rsh==null?Statement.NO_GENERATED_KEY:Statement.RETURN_GENERATED_KEYS);
> this.fillStatement(stmt, params);
> rows = stmt.executeUpdate();
> if(rsh!=null)
> rsh.handle(stmt.getGeneratedKeys());
> } catch (SQLException e) {
> this.rethrow(e, sql, params);
> } finally {
> close(stmt);
> }
> return rows;
> }
> {noformat}
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
