arturobernalg commented on a change in pull request #154:
URL: https://github.com/apache/commons-imaging/pull/154#discussion_r663093689



##########
File path: 
src/main/java/org/apache/commons/imaging/palette/LongestAxisMedianCut.java
##########
@@ -43,7 +43,7 @@ public boolean performNextMedianCut(final List<ColorGroup> 
colorGroups, final bo
                 && colorGroup.alphaDiff > colorGroup.redDiff
                 && colorGroup.alphaDiff > colorGroup.greenDiff
                 && colorGroup.alphaDiff > colorGroup.blueDiff) {
-            doCut(colorGroup, ColorComponent.ALPHA, colorGroups, ignoreAlpha);
+            doCut(colorGroup, ColorComponent.ALPHA, colorGroups, false);

Review comment:
       HI @kinow 
   Changed
   TY

##########
File path: src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
##########
@@ -447,7 +447,7 @@ public void writeImage(final BufferedImage src, final 
OutputStream os, Map<Strin
             final PaletteFactory paletteFactory = new PaletteFactory();
 
             if (hasAlpha) {
-                palette = paletteFactory.makeQuantizedRgbaPalette(src, 
hasAlpha, maxColors);
+                palette = paletteFactory.makeQuantizedRgbaPalette(src, true, 
maxColors);

Review comment:
       HI @kinow 
   Changed
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to