[
https://issues.apache.org/jira/browse/NUMBERS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378452#comment-17378452
]
Matt Juntunen commented on NUMBERS-166:
---------------------------------------
PR: https://github.com/apache/commons-numbers/pull/101
> SortInPlace should not implement BiConsumer
> -------------------------------------------
>
> Key: NUMBERS-166
> URL: https://issues.apache.org/jira/browse/NUMBERS-166
> Project: Commons Numbers
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{SortInPlace}} enum uses a varargs in the method signature that is not
> compatible with the {{BiConsumer}} interface that it implements. The
> interface implementation should be removed and the sort method renamed from
> {{accept}} to {{apply}} to better reflect that the arguments are being
> modified.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
