[
https://issues.apache.org/jira/browse/NUMBERS-166?focusedWorklogId=621263&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621263
]
ASF GitHub Bot logged work on NUMBERS-166:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/21 12:05
Start Date: 10/Jul/21 12:05
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #101:
URL: https://github.com/apache/commons-numbers/pull/101#issuecomment-877627416
[](https://coveralls.io/builds/41267043)
Coverage remained the same at 99.658% when pulling
**437432572b9840ebf7b34efa5e0de35971a38f79 on
darkma773r:numbers-166-sortinplace** into
**4457bfdb65383de0daa9902ad0856f848892f364 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621263)
Time Spent: 20m (was: 10m)
> SortInPlace should not implement BiConsumer
> -------------------------------------------
>
> Key: NUMBERS-166
> URL: https://issues.apache.org/jira/browse/NUMBERS-166
> Project: Commons Numbers
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{SortInPlace}} enum uses a varargs in the method signature that is not
> compatible with the {{BiConsumer}} interface that it implements. The
> interface implementation should be removed and the sort method renamed from
> {{accept}} to {{apply}} to better reflect that the arguments are being
> modified.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
