oneiros-de commented on pull request #777: URL: https://github.com/apache/commons-lang/pull/777#issuecomment-877714792
This is wrong - the "separator" is not an index but a char used by `String#indexof(int)`. See also the unit test `StringUtilsSubstringTest.testSubstringBefore_StringInt` So the description of the method is mostly correct (the description of `separator` is wrong, should be "character (Unicode code point", not "String"); the examples simply don't match the code (the unit test has working examples). An `@see String#indexOf(int)` would help. And this should be done for similar functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
