[
https://issues.apache.org/jira/browse/CSV-278?focusedWorklogId=621764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621764
]
ASF GitHub Bot logged work on CSV-278:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/21 00:34
Start Date: 13/Jul/21 00:34
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#discussion_r668343890
##########
File path: src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
##########
@@ -132,10 +132,24 @@ int lookAhead() throws IOException {
*/
char[] lookAhead(final int n) throws IOException {
final char[] buf = new char[n];
Review comment:
The local var is not needed anymore right?
##########
File path: src/main/java/org/apache/commons/csv/Lexer.java
##########
@@ -153,25 +156,26 @@ boolean isEscape(final int ch) {
}
/**
- * Tests if the next characters constitute a escape delimiter through
{@link ExtendedBufferedReader#lookAhead(int)}.
+ * Tests if the next characters constitute a escape delimiter through
+ * {@link ExtendedBufferedReader#lookAhead(char[])}.
*
Review comment:
Same comment.
##########
File path: src/main/java/org/apache/commons/csv/Lexer.java
##########
@@ -112,25 +116,24 @@ boolean isCommentStart(final int ch) {
}
/**
- * Determine whether the next characters constitute a delimiter through
{@link ExtendedBufferedReader#lookAhead(int)}
+ * Determine whether the next characters constitute a delimiter through
Review comment:
No need to change for formatted, it makes more noise to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621764)
Time Spent: 20m (was: 10m)
> Reuse Buffers in Lexer for Delimiter Detection
> ----------------------------------------------
>
> Key: CSV-278
> URL: https://issues.apache.org/jira/browse/CSV-278
> Project: Commons CSV
> Issue Type: Sub-task
> Reporter: David Mollitor
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
