SethFalco opened a new pull request #92:
URL: https://github.com/apache/commons-beanutils/pull/92
This fixes a few warnings in my code editor. I only did the ones with
obvious/agreeable fixes.
##### `BeanComparator.java`
> Return of boolean expressions should not be wrapped into an "if-then-else"
statement (java:S1126)
Switch final if/else to just return the result of the method.
##### `BeanMap.java`
> Local variables should not be declared and then immediately returned or
thrown (java:S1488)
##### `WrapDynaClass.java`
> Unused assignments should be removed (java:S1854)
##### `SqlTimeConverter.java` / `SqlTimestampConverter.java`
> Track uses of "TODO" tags (java:S1135)
Removed the TO-DOs and updated the docs to inherit the parent docs plus
define the other tags.
##### `BeanMapTestCase.java` / `DynaBeanMapDecoratorTestCase.java`
> Unnecessary @SuppressWarnings("deprecation") Java(536871547)
##### `BeanificationTestCase.java`
> JUnit assertTrue/assertFalse should be simplified to the corresponding
dedicated assertion (java:S5785)
##### `Jira357TestCase.java`
> FIXME the isBar() method returning AbstractTestBean.class as the
Java(536871362)
The test case passes when uncommented already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
