garydgregory commented on a change in pull request #251:
URL: https://github.com/apache/commons-io/pull/251#discussion_r676186513
##########
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -227,7 +227,12 @@ private static Writer initWriter(final File file, final
Object encoding, final b
OutputStream stream = null;
final boolean fileExistedAlready = file.exists();
try {
- stream = Files.newOutputStream(file.toPath(), append ?
StandardOpenOption.APPEND : StandardOpenOption.CREATE);
+ if (append) {
Review comment:
Not sure why the fix has to be exploded into so much code when all you
need is an additional argument to the JRE API. Please see git master for a much
simpler fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
