ali-ghanbari commented on pull request #233:
URL: https://github.com/apache/commons-text/pull/233#issuecomment-886259223


   > @ali-ghanbari , I will review it once I have some spare time. Thanks a lot 
for updating the PR and fixing CI issues.
   > 
   > We can definitely ignore that issue since it is not being introduced here 
(will fix it in a bit). As for the JMH test, we could probably include it in 
the source code (if not already in this PR) and run only when a certain Maven 
profile is activated, or filter the suite with the test, etc.
   > 
   > Thanks
   > Bruno
   
   Thanks a lot!
   FYI, for now JMH is in a separate project.
   I will figure it out how to embed the test code in this project (without 
having name conflicts) and selectively run it using Maven.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to