[
https://issues.apache.org/jira/browse/IO-744?focusedWorklogId=627549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627549
]
ASF GitHub Bot logged work on IO-744:
-------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/21 06:39
Start Date: 26/Jul/21 06:39
Worklog Time Spent: 10m
Work Description: rbri commented on a change in pull request #251:
URL: https://github.com/apache/commons-io/pull/251#discussion_r676328916
##########
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -227,7 +227,12 @@ private static Writer initWriter(final File file, final
Object encoding, final b
OutputStream stream = null;
final boolean fileExistedAlready = file.exists();
try {
- stream = Files.newOutputStream(file.toPath(), append ?
StandardOpenOption.APPEND : StandardOpenOption.CREATE);
+ if (append) {
Review comment:
@garydgregory Thanks for the warm welcome as someone trying to help.
Have done another PR that shows, that your optimized version of the fix now
breaks the ctor with the append option set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 627549)
Time Spent: 1h 20m (was: 1h 10m)
> FileWriterWithEncoding for an existing file no longer truncates the file.
> -------------------------------------------------------------------------
>
> Key: IO-744
> URL: https://issues.apache.org/jira/browse/IO-744
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
> Affects Versions: 2.11.0
> Reporter: Ronald Brill
> Priority: Critical
> Fix For: 2.12.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Creating a new FileWriterWithEncoding for an existing file no longer
> truncates the file. This was the case in the versions before including 2.10.0.
> Starting with 2.11.0 i'm facing issues with files containing my new content
> but still have the old one if the existing file was larger than the new
> content.
>
> commit b2811e86 seems to introduce the problem - i think we should use
> StandardOpenOption.CREATE_NEW instead of StandardOpenOption.CREATE (inside
> the initWriter method)
>
> Please give me a sign if you need more details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
