ali-ghanbari commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r679637832
##########
File path: pom.xml
##########
@@ -503,5 +535,44 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>benchmark</id>
+ <properties>
+ <skipTests>true</skipTests>
+ <benchmark>org.apache</benchmark>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.0.0</version>
+ <executions>
+ <execution>
+ <id>benchmark</id>
Review comment:
Yes @kinow, we do have a JMH benchmark profile already in the latest
version in `master` branch.
I actually copied from there to reduce the risk of conflicts.
> Did you rebase when you added your JMH changes?
I just manually copied relevant parts into `pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
