[
https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=639833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639833
]
ASF GitHub Bot logged work on FILEUPLOAD-340:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/21 13:05
Start Date: 19/Aug/21 13:05
Worklog Time Spent: 10m
Work Description: martin-g commented on pull request #107:
URL:
https://github.com/apache/commons-fileupload/pull/107#issuecomment-901898390
> You should pre-build your module file and include it moditect, but
definitely do not auto generate from it
@GedMarc You mean we should not include the `impl` package (added by the
auto-generation) ?
I am afraid this will break many applications which already use classes from
`impl`. I know that Apache Wicket does use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 639833)
Time Spent: 1h 20m (was: 1h 10m)
> Make commons-fileupload a proper JPMS module
> --------------------------------------------
>
> Key: FILEUPLOAD-340
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340
> Project: Commons FileUpload
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Martin Tzvetanov Grigorov
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It would be nice if 2.0 provides module-info.class for Java 9+ JPMS.
>
> At the moment the project uses JDK 1.8 for the builds.
> To add module-info.java it would have to use JDK 9+ (probably 11) with
> -release=1.8.
> An easy way to introduce module-info.java is by using
> [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
