[
https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=640217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640217
]
ASF GitHub Bot logged work on FILEUPLOAD-342:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/21 12:19
Start Date: 20/Aug/21 12:19
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #109:
URL:
https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897
[](https://coveralls.io/builds/42296738)
Coverage decreased (-0.02%) to 78.1% when pulling
**79d91fd9f5b803dca23ca269b073361de051e6e3 on
martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into
**8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 640217)
Time Spent: 0.5h (was: 20m)
> FileUploadBase should not import HttpServletRequest
> ---------------------------------------------------
>
> Key: FILEUPLOAD-342
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342
> Project: Commons FileUpload
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Martin Tzvetanov Grigorov
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> FileUploadBase has few deprecated methods which use
> 'javax.servlet.http.HttpServletRequest`.
>
> This causes class loading problem when using the new Jakarta based
> `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because
> javax.servlet.** in not on the classpath.
>
> Would it be OK to remove the deprecated methods in 2.0 ?
> The applications should use
> org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent()
> or
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent()
> instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
