[
https://issues.apache.org/jira/browse/DBCP-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niall Pemberton updated DBCP-310:
---------------------------------
Comment: was deleted
(was: OK, then we should consistently use the ,initCause(e) method and remove
all references that throw SQLNestedException.
Attaching a new patch)
> SQLNestedException & use of initCause() with SQLException
> ---------------------------------------------------------
>
> Key: DBCP-310
> URL: https://issues.apache.org/jira/browse/DBCP-310
> Project: Commons Dbcp
> Issue Type: Improvement
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 1.3, 1.4
>
> Attachments: DBCP-310-v2.patch, SQLNestedException.patch
>
>
> SQLNestedException in its current state is a hangover from supporting JDK 1.3
> when there was no "initCause()" method. This implementation can now be
> greatly simplified with DBCP now having a minimum of JDK 1.4
> Also SQLNestedException is deprecated and the following code has been used in
> a number of places
> {code}
> throw (SQLException )new SQLException(message).initCause(e)
> {code}
> DBCP is inconsistent though - sometimes using the above and sometimes using
> SQLNestedException. IMO SQLNestedException should be un-deprecated and used
> consistently everywhere - its now a simple implementation and I think the
> code is cleaner using it rather than the above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
