[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=646160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646160
]
ASF GitHub Bot logged work on LANG-1593:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/21 03:25
Start Date: 03/Sep/21 03:25
Worklog Time Spent: 10m
Work Description: HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r701557984
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##########
@@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {
assertNull(StringUtils.join((short[]) null, SEPARATOR_CHAR, 0, 1));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 0, 0));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 1, 0));
+ assertEquals("1,2", StringUtils.join(SHORT_PRIM_LIST, SEPARATOR));
Review comment:
The joining part is done via ```java.util.StringJoiner``` with accepts
only```CharSequence``` in constructor, so it's made to use more than one
character as separator by default. Don't you think that testing that would be
redundant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 646160)
Time Spent: 6h 40m (was: 6.5h)
> Common behaviour for StringUtils join APIs when called with char or String
> delimiter
> ------------------------------------------------------------------------------------
>
> Key: LANG-1593
> URL: https://issues.apache.org/jira/browse/LANG-1593
> Project: Commons Lang
> Issue Type: Improvement
> Affects Versions: 3.4, 3.11
> Reporter: Kiruahxh
> Priority: Minor
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> For now, join(int[], char) is working well.
> However, the same join method called with a string delimiter behaves
> differently : it returns a single memory address which is not the desired
> behavior.
> I think that, for coherence, calling StringUtils with a char or String
> delimiter should return the exact same value.
> Ex :
> {code:java}
> CLASSPATH="./commons-lang3-3.11.jar" jshell
> | Welcome to JShell -- Version 11.0.8
> jshell> import org.apache.commons.lang3.StringUtils
> jshell> int[] arr = {1, 2, 3, 4, 5, 6, 7};
> jshell> String result = StringUtils.join(arr, '-');
> result ==> "1-2-3-4-5-6-7"
> jshell> String result = StringUtils.join(arr, "-");
> result ==> "[I@69663380-"
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
