[
https://issues.apache.org/jira/browse/IO-727?focusedWorklogId=646362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646362
]
ASF GitHub Bot logged work on IO-727:
-------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/21 16:09
Start Date: 03/Sep/21 16:09
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #217:
URL: https://github.com/apache/commons-io/pull/217#discussion_r702015507
##########
File path:
src/test/java/org/apache/commons/io/FileUtilsDirectoryContainsTestCase.java
##########
@@ -134,9 +134,16 @@ public void testSameFile() throws IOException {
}
@Test
- public void testIO466() throws IOException {
Review comment:
Please don't remove an existing test, it makes reviewing harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646362)
Time Spent: 50m (was: 40m)
> FilenameUtils.directoryContains() and FileUtils.directoryContains() return
> wrong result when parent and child have the same path prefix
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: IO-727
> URL: https://issues.apache.org/jira/browse/IO-727
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Reporter: Trung Pham
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> FilenameUtils.directoryContains() and FileUtils.directoryContains() will
> return `true` with the following input.
> {code:java}
> canonicalParent: /path/foo
> canonicalChild: /path/foobar
> {code}
> There were several issues on this but the problem still remains.
> IO-423 didn't do anything.
> IO-466 test case added in
> [676c03|https://github.com/apache/commons-io/commit/67325cf97946f053da51dd358a9ffca0a9676c03]
> just happened to passed because the input file didn't exist.
> Github PR: https://github.com/apache/commons-io/pull/217
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
