[
https://issues.apache.org/jira/browse/IMAGING-310?focusedWorklogId=646601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646601
]
ASF GitHub Bot logged work on IMAGING-310:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/21 13:21
Start Date: 04/Sep/21 13:21
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #163:
URL: https://github.com/apache/commons-imaging/pull/163#issuecomment-912973601
Thanks for the pull request and sorry for taking so long to review it
@jephillips34 . Will try to get on it in the next days :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646601)
Time Spent: 0.5h (was: 20m)
> JpegImageParser: Grayscale JPEG file with app14Segment returns
> ColorType.UNKNOWN
> --------------------------------------------------------------------------------
>
> Key: IMAGING-310
> URL: https://issues.apache.org/jira/browse/IMAGING-310
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
> Affects Versions: 1.0-alpha2
> Reporter: John Phillips
> Priority: Major
> Attachments: sample-grayscale-with-app14segment.jpg
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In org.apache.commons.imaging.formats.jpeg. the logic to determine colorType
> (lines 825-970) does not account for a Grayscale image when there is an app14
> segment present.
> When the number of components is 1 or 2, the colorType should always be
> Grayscale. None of the other logic would change that.
> It seems to me that the switch (numberOfComponents) statement should be moved
> to the top of this bit of code, and the rest of the logic should handled
> under Case 3 & 4:
> {noformat}
> // See
> http://docs.oracle.com/javase/6/docs/api/javax/imageio/metadata/doc-files/jpeg_metadata.html#color
> ImageInfo.ColorType colorType = ImageInfo.ColorType.UNKNOWN;
> switch (numberOfComponents) {
> case 1:
> colorType = ImageInfo.ColorType.GRAYSCALE;
> break;
>
> case 2:
> colorType = ImageInfo.ColorType.GRAYSCALE;
> transparent = true;
> break;
>
> case 3:
> case 4:
> // Some images have both JFIF/APP0 and APP14.
> // JFIF is meant to win but in them APP14 is clearly right, so make it
> win.
> if (app14Segment != null && app14Segment.isAdobeJpegSegment()) {
> etc.
> {noformat}
> Attached sample-grayscale-with-app14segment.jpg, which can be used to
> demonstrate the issue.
> I've modified the code locally, but I'm a newbie at submitting
> pull-requests....
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
