gwlucastrig commented on a change in pull request #165:
URL: https://github.com/apache/commons-imaging/pull/165#discussion_r706662585
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderTiled.java
##########
@@ -286,7 +288,20 @@ public ImageBuilder readImageData(final Rectangle
subImageSpecification,
@Override
public TiffRasterData readRasterData(final Rectangle subImage)
- throws ImageReadException, IOException {
+ throws ImageReadException, IOException {
+ switch (sampleFormat) {
+ case TiffTagConstants.SAMPLE_FORMAT_VALUE_IEEE_FLOATING_POINT:
Review comment:
It took a bit of searching to find what this is about.
public static final int SAMPLE_FORMAT_VALUE_COMPLEX_INTEGER = 5;
public static final int SAMPLE_FORMAT_VALUE_IEEE_FLOATING_POINT_1 = 6;
Sample formats 5 (complex integer) and 6 (complex float) are not actually
part of the TIFF spec, but seem to have been introduced by LibTIFF at some
point. There is no support for complex-conjugate-pairs in Commons Imaging at
this time. Neither of these values are used elsewhere in the the code.
At the very least, I will rename FLOATING_POINT_1 to be COMPLEX_FLOAT.
You can read more at
[Extension TIFF Tag Sample
Format](https://www.awaresystems.be/imaging/tiff/tifftags/sampleformat.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
