[
https://issues.apache.org/jira/browse/FILEUPLOAD-341?focusedWorklogId=649984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649984
]
ASF GitHub Bot logged work on FILEUPLOAD-341:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/21 12:43
Start Date: 13/Sep/21 12:43
Worklog Time Spent: 10m
Work Description: jochenw merged pull request #108:
URL: https://github.com/apache/commons-fileupload/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 649984)
Time Spent: 20m (was: 10m)
> Move exceptions out of .impl package
> ------------------------------------
>
> Key: FILEUPLOAD-341
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341
> Project: Commons FileUpload
> Issue Type: Wish
> Affects Versions: 2.0
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Jochen Wiedmann
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that
> exports all packages but org.apache.commons.fileupload2.impl.
>
> Would it be OK to move all **Exception classes to the parent package so that
> they are visible by users ?
> **Impl classes should stay in org.apache.commons.fileupload2.impl!
>
> In Apache Wicket we use few of the exception classes to report specific
> errors:
> *
> [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505]
> *
> [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
