[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414760#comment-17414760
 ] 

Martin Tzvetanov Grigorov commented on FILEUPLOAD-341:
------------------------------------------------------

[~b.eckenfels] I've added a note about this change in the migration guide with 
[https://github.com/apache/commons-fileupload/commit/e90f744bf1f9ffb92db858dc104be86fdbd9c420]

Apache Wicket does not need any more breaking changes in fileupload2!

Current master works quite good with JPMS and Jakarta APIs for us!

A milestone release would be appreciated!

> Move exceptions out of .impl package
> ------------------------------------
>
>                 Key: FILEUPLOAD-341
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-341
>             Project: Commons FileUpload
>          Issue Type: Wish
>    Affects Versions: 2.0
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Jochen Wiedmann
>            Priority: Minor
>             Fix For: 2.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that 
> exports all packages but org.apache.commons.fileupload2.impl.
>  
> Would it be OK to move all **Exception classes to the parent package so that 
> they are visible by users ?
> **Impl classes should stay in org.apache.commons.fileupload2.impl!
>  
> In Apache Wicket we use few of the exception classes to report specific 
> errors:
>  * 
> [https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505]
>  * 
> [https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to