[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=650480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650480 ]
ASF GitHub Bot logged work on IO-747: ------------------------------------- Author: ASF GitHub Bot Created on: 14/Sep/21 10:28 Start Date: 14/Sep/21 10:28 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919023495 One minor nitpick: As I understand it, there is now a hardcoded version 8 for the Java compiler. IIRC, there is a property in commons-parent for that. Please, change that to use that property. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 650480) Time Spent: 2h 20m (was: 2h 10m) > Make commons-io a proper JPMS module > ------------------------------------ > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task > Affects Versions: 2.12.0 > Reporter: Martin Tzvetanov Grigorov > Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)