garydgregory commented on pull request #32:
URL: https://github.com/apache/commons-io/pull/32#issuecomment-922490803
Hi @jonfreedman,
Thank you for your patience.
Please see git master for the new implementation. I committed the changes
from this PR combined with:
- Use `Objects.requireNonNull()` instead manual checks.
- Normalize Javadoc.
- Add missing Javadoc.
- Add missing Javadoc tags.
- Sort members.
- Don't initialize ivars to defaults.
- Renamed some types, ivars, and params.
- Fix some Javadoc.
- No need to use FQCNs in Javadoc @link.
- Use `{@code}` instead of `<code></code>`.
- YAGNI: Remove some methods that are not tested and never called.
- Re-implement some internals using NIO.
- Add some constructor parameter validation.
- Add a toString() method.
May you please make sure your use case is satisfied?
If you want the code to do more, please rebase on master or provide a new PR.
TY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
