akalexus commented on a change in pull request #806:
URL: https://github.com/apache/commons-lang/pull/806#discussion_r711771885
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##########
@@ -1384,6 +1384,40 @@ public void testJoinWith() {
assertEquals("ab", StringUtils.joinWith(null, "a", "b"));
}
+ @Test
+ public void testJoinNotEmptyWith() {
+ assertEquals("", StringUtils.joinNotEmptyWith(",")); // empty
array
+ assertEquals("", StringUtils.joinNotEmptyWith(",", (Object[])
NULL_ARRAY_LIST));
+ assertEquals("", StringUtils.joinNotEmptyWith(",",
NULL_TO_STRING_LIST));
+
+ assertEquals("a,b", StringUtils.joinNotEmptyWith(",", "a", "b"));
+ assertEquals("a,b, ", StringUtils.joinNotEmptyWith(",", "a", "b", "
"));
+ assertEquals("a,b", StringUtils.joinNotEmptyWith(",", "", "a", null,
"b"));
+ assertEquals("ab", StringUtils.joinNotEmptyWith(null, "a", "b"));
+ assertEquals("a b", StringUtils.joinNotEmptyWith(null, "a", " ", "b"));
+ }
+
+ @Test
+ public void testJoinNotBlankWith() {
+ assertEquals("", StringUtils.joinNotBlankWith(",")); // empty
array
+ assertEquals("", StringUtils.joinNotBlankWith(",", (Object[])
NULL_ARRAY_LIST));
+ assertEquals("", StringUtils.joinNotBlankWith(",",
NULL_TO_STRING_LIST));
+
+ /*
Review comment:
Remove this comment, pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
