[
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=652758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652758
]
ASF GitHub Bot logged work on IO-726:
-------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/21 02:13
Start Date: 20/Sep/21 02:13
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-922598115
@shollander
I modified this PR 215 for git master with:
- Do not write the console.
- Simplify cleaner check support.
- Simplify exception handling.
- Don't initialize instance variables to their default values.
- Un-nest else clause.
- Declaring interfaces as static is redundant.
- Use EOF constant instead of magic number.
- Don't throw RuntimeException, use IllegalStateException.
- Pacakge private class does not need public method.
- Use final.
- Improve Javadocs.
- Javadoc sentences should end in a period.
- Javadoc do not need first sentence to be in an HTML p element.
- No need to use `this.` when you do not need to.
- In-line some single use variables.
- Sort members.
Please check it out. Feel free to rebase this PR on master or provide a new
PR if you need more for your use case.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 652758)
Time Spent: 5h 10m (was: 5h)
> Add MemoryMappedInputStream
> ---------------------------
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
> Affects Versions: 2.8.0
> Reporter: S Hollander
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of
> memory mapped files. I propose an {{InputStream}} that provides a bridge
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream
> provided a 25% increase in throughput.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
