[ 
https://issues.apache.org/jira/browse/IO-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418438#comment-17418438
 ] 

Sita Geßner commented on IO-750:
--------------------------------

Hi [~ggregory],

WildcardFilter is marked as deprecated with the deprecationnote to use 
WildcardFileFilter.

I think FileUtils.iterateFiles should never select directories. The javadoc 
says:

{noformat}
Iterates over the files in given directory (and optionally its subdirectories)
{noformat}

The WildcardFileFilter * should be interpreted as "all files". It can be 
checked with 

{code:java}
!file.isDirectory()
{code}



> FileUtils.iterateFiles lists directorys with WildcardFileFilter *
> -----------------------------------------------------------------
>
>                 Key: IO-750
>                 URL: https://issues.apache.org/jira/browse/IO-750
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 2.9.0
>            Reporter: Sita Geßner
>            Priority: Major
>
> After updating commons-io from 2.8.0 to 2.9.0 the method 
> FileUtils.iterateFiles also returns directories.
> Codeexample:
> {code:java}
>         final File directory = new File(FileUtils.getTempDirectory(), "TEST");
>         directory.mkdir();
>         new File(directory, "TEST").mkdir();
>         new File(directory, "test.txt").createNewFile();
>         final IOFileFilter filter = new WildcardFileFilter("*", 
> IOCase.INSENSITIVE);
>         for (final Iterator<File> itFiles = FileUtils.iterateFiles(directory, 
> filter, null); itFiles
>                 .hasNext();) {
>             final File file = itFiles.next();
>             System.out.println(file.getAbsolutePath());
>         }
> {code}
> result in version 2.8.0:
> {noformat}
> /tmp/TEST/test.txt
> {noformat}
> result from version 2.9.0:
> {noformat}
> /tmp/TEST/test.txt
> /tmp/TEST/TEST
> {noformat}
> iterateFiles shouldn't return directories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to