garydgregory commented on a change in pull request #39:
URL: https://github.com/apache/commons-io/pull/39#discussion_r715037670
##########
File path:
src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
##########
@@ -134,17 +133,35 @@ public ReversedLinesFileReader(final File file, final int
blockSize, final Chars
// Open file
randomAccessFile = new RandomAccessFile(file, "r");
totalByteLength = randomAccessFile.length();
- int lastBlockLength = (int) (totalByteLength % blockSize);
- if (lastBlockLength > 0) {
- totalBlockCount = totalByteLength / blockSize + 1;
+ seek (totalByteLength);
+
+ }
+ /**
Review comment:
All new public and protected method should have complete Javadoc. Here
the first sentence is missing as is the since tag.
##########
File path:
src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
##########
@@ -361,6 +383,13 @@ private int getNewLineMatchByteCount(final byte[] data,
final int i) {
}
return 0;
}
+
+ /**
+ * @return Returns the current offset in this file
+ */
+ public long getFilePointer(){
Review comment:
Formatting is missing a space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
