[
https://issues.apache.org/jira/browse/COLLECTIONS-796?focusedWorklogId=654742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654742
]
ASF GitHub Bot logged work on COLLECTIONS-796:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/21 20:49
Start Date: 23/Sep/21 20:49
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #255:
URL:
https://github.com/apache/commons-collections/pull/255#discussion_r715140917
##########
File path:
src/main/java/org/apache/commons/collections4/iterators/UnmodifiableListIterator.java
##########
@@ -53,6 +53,14 @@
return new UnmodifiableListIterator<>(iterator);
}
+ /**
+ * use
"org.apache.commons.collections4.iterators.UnmodifiableListIterator#unmodifiableListIterator"
instead.
Review comment:
Would need the @deprecated javadoc here too to help IDE's I think?
##########
File path:
src/main/java/org/apache/commons/collections4/iterators/UnmodifiableListIterator.java
##########
@@ -53,6 +53,14 @@
return new UnmodifiableListIterator<>(iterator);
}
+ /**
+ * use
"org.apache.commons.collections4.iterators.UnmodifiableListIterator#unmodifiableListIterator"
instead.
+ */
+ @Deprecated
+ public static <E> ListIterator<E> umodifiableListIterator(final
ListIterator<? extends E> iterator) {
Review comment:
:+1: thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 654742)
Remaining Estimate: 40m (was: 50m)
Time Spent: 20m (was: 10m)
> SetUniqueList.createSetBasedOnList doesn't add list elements to return value
> ----------------------------------------------------------------------------
>
> Key: COLLECTIONS-796
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-796
> Project: Commons Collections
> Issue Type: Bug
> Components: List
> Affects Versions: 4.3, 4.4
> Reporter: Owen Mansel-Chan
> Priority: Minor
> Labels: easyfix, newbie
> Original Estimate: 1h
> Time Spent: 20m
> Remaining Estimate: 40m
>
> SetUniqueList.createSetBasedOnList doesn't add list elements to the return
> value any more. The documentation says it does, and it used to up to version
> 4.2, but a call to `addAll` was accidentally deleted. I found where the
> mistake was introduced on github:
> https://github.com/apache/commons-collections/commit/b1c45ac691d46a8c609f2534d2adfa59c0599527#diff-8e53271d5d8299a76d43b0e3c81740fbe660083ae71c5bf2be63846d52156f23L344
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
