[
https://issues.apache.org/jira/browse/IO-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421533#comment-17421533
]
Gary D. Gregory commented on IO-751:
------------------------------------
{quote}Make PathUtils.setReadOnly(...) have no effect at all on POSIX system.
After all, these systems don't have a read-only attribute that could be set or
unset.
{quote}
That does not seem acceptable IMO; as a user of the API, I do not care HOW the
underlying file system implements read-only, I just want my file to be readable
and writable (or not).
- Read-only true: Allow reading, forbid writing.
- Read-only false: Allow reading, allow writing.
So for POSIX (in git master now), the semantics of read are now:
{code:java}
final PosixFileAttributes readAttributes =
posixFileAttributeView.readAttributes();
final Set<PosixFilePermission> permissions =
readAttributes.permissions();
permissions.add(PosixFilePermission.OWNER_READ);
permissions.add(PosixFilePermission.GROUP_READ);
permissions.add(PosixFilePermission.OTHERS_READ);
List<PosixFilePermission> writePermissions =
Arrays.asList(PosixFilePermission.OWNER_WRITE, PosixFilePermission.GROUP_WRITE,
PosixFilePermission.OTHERS_WRITE);
if (readOnly) {
permissions.removeAll(writePermissions);
} else {
permissions.addAll(writePermissions);
}
...
return Files.setPosixFilePermissions(path, permissions);
...
{code}
> When deleting symlinks, File/PathUtils.deleteDirectory() changes file
> permissions of the target
> -----------------------------------------------------------------------------------------------
>
> Key: IO-751
> URL: https://issues.apache.org/jira/browse/IO-751
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.11.0
> Environment: macOS 11.5.2
> OpenJDK 11
> Reporter: Richard Cyganiak
> Priority: Major
> Attachments: DeleteDirectoryTest.java, commons-io.patch
>
>
> When {{FileUtils.deleteDirectory(...)}} and
> {{PathUtils.deleteDirectory(...)}} encounter a symlink while recursively
> deleting, the default behaviour is to delete the symlink, but leave the
> target of the symlink alone. This works for the most part: the symlink is
> correctly deleted, and the target is not deleted or recursed into.
> However, the methods _alter the file permissions of the target_:
> - {{FileUtils.deleteDirectory(file)}} _removes_ all write permissions from
> the target
> - {{PathUtils.deleteDirectory(path,
> StandardDeleteOption.OVERRIDE_READ_ONLY)}} _removes_ all write permissions,
> and _adds_ all execute permissions (even if the target is a file, not a
> directory)
> - {{PathUtils.deleteDirectory(path)}} works correctly and does not change the
> target's permissions
> A JUnit 4 test case that demonstrates the behaviour of all three methods is
> attached.
> The behaviour is unexpected (the Javadocs give no hint), inconvenient (it
> leaves the owner of the target without write permission) and potentially
> dangerous (it adds execute permissions for anyone).
> It appears the implementation assumes it can freely modify permissions
> because it is going to delete the file/directory anyway, and the case of
> symlinks was simply not considered. The handling of write permissions is
> particularly puzzling. I could understand why an implementation would _add_
> write permission, but why _remove_ it?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
