Hubert Wojciechowski created LANG-1675:
------------------------------------------

             Summary: Improve performance of StringUtils.join for primitives.
                 Key: LANG-1675
                 URL: https://issues.apache.org/jira/browse/LANG-1675
             Project: Commons Lang
          Issue Type: Improvement
            Reporter: Hubert Wojciechowski


This is [~XenoAmess] comment from PR:  
[https://github.com/apache/commons-lang/pull/784] 


{noformat}
Please look at the sources in JDK, where 
java.lang.AbstractStringBuilder#append(boolean b)

In short, for basic types, should not convert them to String, but use 
StringBuilder directly, will bring far better performance.

BUT I just foundout that you did not bring this issue, this issue is already in 
commons-lang before your pr.

So I will not stop you from merging this in, but still I will find time to 
refactor the whole join serial functions later.
{noformat}

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to