Claudenw opened a new pull request #258: URL: https://github.com/apache/commons-collections/pull/258
# This is a work in progress -- please review but do not merge While this looks like a massive change, most of the change is removing the hashing management complexity. The stripped down version no longer tracks the hashing protocol and assumes that this is the responsibility of the projects that use this library. Hashing classes have been reduced to 2 implementations and one interface. The hasher implementation expects a hash to be generated and passed to it to use. Other implementations that use hash functions directly are possible but not implemented here. The complexity of the BloomFilter has been reduced. The internal representation of the filter is no longer exposed directly. Instead, BitMapProducer and IndexProducer interfaces are implemented to allow IntConsumers and LongConsumers to receive representations of the internal structures. The CountingBloomFilter uses BitCountProducer for to retrieve the index and count values. Bloom filters merge() now produces a new Bloom filter while mergeInPlace() modifies the current Bloom filter. Shape has been simplified to only track the numberOfBits and numberOfHashFunction. A Shape.Factory has been added to create shapes from standard requests (e.g. numberOfItems and probabilityOfCollision) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
