[
https://issues.apache.org/jira/browse/COLLECTIONS-793?focusedWorklogId=663123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663123
]
ASF GitHub Bot logged work on COLLECTIONS-793:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/21 05:54
Start Date: 09/Oct/21 05:54
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #233:
URL:
https://github.com/apache/commons-collections/pull/233#discussion_r725438173
##########
File path:
src/test/java/org/apache/commons/collections4/iterators/ArrayIteratorTest.java
##########
@@ -56,14 +56,12 @@ public void testIterator() {
assertEquals("Iteration value is correct", testValue, iterValue);
}
- assertTrue("Iterator should now be empty", !iter.hasNext());
+ assertFalse("Iterator should now be empty", iter.hasNext());
try {
iter.next();
} catch (final Exception e) {
- assertTrue(
- "NoSuchElementException must be thrown",
- e.getClass().equals(new NoSuchElementException().getClass()));
+ assertEquals("NoSuchElementException must be thrown",
e.getClass(), new NoSuchElementException().getClass());
Review comment:
Was going to suggest using `assertThrows`, but we can fix that later,
and this PR is long enough already 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663123)
Time Spent: 0.5h (was: 20m)
> Simplify Assertion
> ------------------
>
> Key: COLLECTIONS-793
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-793
> Project: Commons Collections
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
