[
https://issues.apache.org/jira/browse/LANG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426568#comment-17426568
]
Hubert Wojciechowski commented on LANG-1675:
--------------------------------------------
PR created:
[https://github.com/apache/commons-lang/pull/812]
JMH tests with example results are here:
[https://github.com/HubertWo/apache-commons-lang-jmh]
> Improve performance of StringUtils.join for primitives.
> -------------------------------------------------------
>
> Key: LANG-1675
> URL: https://issues.apache.org/jira/browse/LANG-1675
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: Hubert Wojciechowski
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is [~XenoAmess] comment from PR:
> [https://github.com/apache/commons-lang/pull/784]
> {noformat}
> Please look at the sources in JDK, where
> java.lang.AbstractStringBuilder#append(boolean b)
> In short, for basic types, should not convert them to String, but use
> StringBuilder directly, will bring far better performance.
> BUT I just foundout that you did not bring this issue, this issue is already
> in commons-lang before your pr.
> So I will not stop you from merging this in, but still I will find time to
> refactor the whole join serial functions later.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
