aherbert commented on a change in pull request #32:
URL: https://github.com/apache/commons-statistics/pull/32#discussion_r725487112
##########
File path:
commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/DistributionException.java
##########
@@ -53,6 +53,6 @@
* @param formatArguments Arguments for formatting the message.
*/
DistributionException(String message, Object... formatArguments) {
- super(String.format((Locale) null, message, formatArguments));
+ super(String.format( null, message, formatArguments));
Review comment:
I think we should use Locale.ROOT. This will make it clear the messages
are language/country neutral.
Note that I do not think it currently makes any difference as the message
use %s for double values. This will produce a formatted string as if using
String.valueOf(double) which is Locale neutral. But using Locale.ROOT indicates
for future reference the messages are locale neutral.
I've pushed a change to master. Please verify and close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
