[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427679#comment-17427679
]
Gilles Sadowski commented on NUMBERS-167:
-----------------------------------------
bq. {{ComplementaryFunctions}} interface [...] should be elevated to the
package level.
>From a programming POV certainly, but I'm not sure about the proper naming...
Another (unrelated) issue: I think that we should really have
{code}
public enum RegularizedGamma {
P(...),
Q(...);
// Methods for generating "ComplementaryFunctions" instances.
}
{code}
instead of the current
{code}
public class RegularizedGamma {
public enum RG {
P(...),
Q(...);
// ...
}
public static class P { ... }
public static class Q { ... }
}
{code}
Do you know whether the change could be done while retaining BC?
> RegularizedGamma.P with precomputed LogGamma value
> --------------------------------------------------
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
> Reporter: Gilles Sadowski
> Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
