[
https://issues.apache.org/jira/browse/MATH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791454#action_12791454
]
Larry Diamond commented on MATH-323:
------------------------------------
Oh my this is embarrassing. You're right Luc. I messed up the algo when
copying it from my source.
When computing the Sortino ratio, you're eliminating the losses - so the code
is correct for the Sortino ratio but is not truly semivariance.
For anything below the mean, you should replace the value with the mean for the
original distribution. I had zero adjusted the distribution before I called
the method.
I'll do a rewrite on this code and reattach it to this issue. Thank you for
reviewing the code! I am so embarrassed!
> Add Semivariance calculation
> ----------------------------
>
> Key: MATH-323
> URL: https://issues.apache.org/jira/browse/MATH-323
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 2.1
> Reporter: Larry Diamond
> Assignee: Phil Steitz
> Priority: Minor
> Fix For: 2.1
>
> Attachments: patch.txt, StatUtils.java, StatUtilsTest.java
>
>
> I've added semivariance calculations to my local build of commons-math and I
> would like to contribute them.
> Semivariance is described a little bit on
> http://en.wikipedia.org/wiki/Semivariance , but a real reason you would use
> them is in finance in order to compute the Sortino ratio rather than the
> Sharpe ratio.
> http://en.wikipedia.org/wiki/Sortino_ratio gives an explanation of the
> Sortino ratio and why you would choose to use that rather than the Sharpe
> ratio. (There are other ways to measure the performance of your portfolio,
> but I wont bore everybody with that stuff)
> I've already got the coding completed along with the test cases and building
> using mvn site.
> The only two files I've modified is
> src/main/java/org/apache/commons/stat/StatUtils.java and
> src/test/java/org/apache/commons/math/stat/StatUtilsTest.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
