aherbert commented on pull request #817:
URL: https://github.com/apache/commons-lang/pull/817#issuecomment-944213218
What would you expect the method to do when calling this?:
```java
Fraction.getFraction("B<D|J*"");
```
This is not a fraction of type `X Y/Z`, `Y/Z` or `Y`, with each of `X, Y, Z`
being integers; or `X.Y` using a floating-point representation. If the format
does not match this pattern then throwing an exception is the expected
behaviour.
Your code change wraps the entire logic block in a try-catch to catch a
NumberFormatException and then throws a new NumberFormatException without the
stack trace and offending string that caused it. This is not useful and should
be removed.
Can you add some unit tests to show what cases are currently not working and
then update the code to pass the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
