[
https://issues.apache.org/jira/browse/LANG-1676?focusedWorklogId=666034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666034
]
ASF GitHub Bot logged work on LANG-1676:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/21 12:54
Start Date: 17/Oct/21 12:54
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #815:
URL: https://github.com/apache/commons-lang/pull/815#discussion_r730411096
##########
File path: src/test/java/org/apache/commons/lang3/RangeTest.java
##########
@@ -306,6 +306,7 @@ public void testIsOverlappedBy() {
// easy inside range
assertTrue(intRange.isOverlappedBy(Range.between(12, 18)));
+ assertTrue(intRange.isOverlappedBy(Range.between(5, 25)));
Review comment:
Hello @Rushi98
TY for your PR!
This assert call was initially confusing to me because [5,25] is not the
same kind of test as "easy inside range", it overlaps the _whole_ range, it is
not _inside_ it like [12, 18] above it. To speed up the process, I've added a
different test with a new comment in git master. Please verify and propose more
if I think we are still missing a condition or use-case.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 666034)
Time Spent: 20m (was: 10m)
> another case for RangeTest.isOverlapped
> ---------------------------------------
>
> Key: LANG-1676
> URL: https://issues.apache.org/jira/browse/LANG-1676
> Project: Commons Lang
> Issue Type: Test
> Components: lang.*
> Reporter: Rushikesh Jogdand
> Priority: Trivial
> Labels: unit-test-missing
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add test for case –
> when other range fully contains this range, this.isOverlapped(other) should
> return true.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
