[ 
https://issues.apache.org/jira/browse/LANG-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb closed LANG-567.
---------------------

    Resolution: Fixed

Added test.
Changed code to catch ArrayStoreException and report IllegalArgument if types 
are not compatible

URL: http://svn.apache.org/viewvc?rev=892114&view=rev
Log:
LANG-567 - ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed 
types very well
Also remove unnecessary main() and suite() from test class

> ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed types very 
> well
> --------------------------------------------------------------------------------
>
>                 Key: LANG-567
>                 URL: https://issues.apache.org/jira/browse/LANG-567
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed array types 
> very well.
> The stack trace for 
> Number[] st = ArrayUtils.addAll(new Integer[]{1}, new Long[]{2L});
> starts:
> java.lang.ArrayStoreException
>       at java.lang.System.arraycopy(Native Method)
>       at org.apache.commons.lang3.ArrayUtils.addAll(ArrayUtils.java:2962)
> which is not all that obvious.
> It would be a lot clearer if the method threw an IlegalArgumentException or 
> similar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to