[ 
https://issues.apache.org/jira/browse/CSV-292?focusedWorklogId=669412&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669412
 ]

ASF GitHub Bot logged work on CSV-292:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Oct/21 09:32
            Start Date: 25/Oct/21 09:32
    Worklog Time Spent: 10m 
      Work Description: rvesse opened a new pull request #191:
URL: https://github.com/apache/commons-csv/pull/191


   Ensure that the resulting Commons CSV JAR file can be used in JPMS based
   projects
   
   Prior to this change the JAR is missing the `Automatic-Module-Name` entry in 
its
   manifest meaning it cannot be used in JPMS based projects (e.g. 
rvesse/airline#106) yielding errors like the following:
   
   ```
   Error occurred during initialization of boot layer
   java.lang.module.FindException: Module org.apache.commons.csv not found, 
required by com.github.rvesse.airline.examples
   ```
   
   With this change JPMS based projects can successfully use Commons CSV 
without errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 669412)
    Remaining Estimate: 0h
            Time Spent: 10m

> No Automatic-Module-Name prevents usage in JPMS projects without repacking 
> the JAR
> ----------------------------------------------------------------------------------
>
>                 Key: CSV-292
>                 URL: https://issues.apache.org/jira/browse/CSV-292
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.8, 1.9.0
>         Environment: JPMS application
>            Reporter: Rob Vesse
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the Commons CSV release JAR does not include an 
> {{Automatic-Module-Name}} meaning it cannot be used in JPMS based projects, 
> any attempt to do so results in errors like the following:
> {noformat}
> Error occurred during initialization of boot layer
> java.lang.module.FindException: Module org.apache.commons.csv not found, 
> required by com.github.rvesse.airline.examples
> {noformat}
> Whereas other Commons modules e.g. Lang, do have {{Automatic-Module-Name}} 
> present and can be used in a JPMS based project.
> Digging into the {{pom.xml}} it looks like the difference between the two 
> modules is that Lang adds JAR plugin configuration to add the 
> {{Automatic-Module-Name}} whereas CSV does not.  Copying the configuration 
> across between the modules should be sufficient to resolve this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to