[
https://issues.apache.org/jira/browse/IO-756?focusedWorklogId=676738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676738
]
ASF GitHub Bot logged work on IO-756:
-------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 21:13
Start Date: 04/Nov/21 21:13
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #296:
URL: https://github.com/apache/commons-io/pull/296#discussion_r743203274
##########
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -59,7 +57,7 @@
* @return the initialized writer
* @throws IOException if an error occurs
*/
- private static Writer initWriter(final File file, final Object encoding,
final boolean append) throws IOException {
+ private static final Writer initWriter(final File file, final Object
encoding, final boolean append) throws IOException {
Review comment:
This one is not really necessary @wodencafe ? `initWriter` is already
private, so making it `final` won't change much for internal/external devs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 676738)
Time Spent: 1h 40m (was: 1.5h)
> Update FileWriterWithEncoding to extend ProxyWriter
> ---------------------------------------------------
>
> Key: IO-756
> URL: https://issues.apache.org/jira/browse/IO-756
> Project: Commons IO
> Issue Type: Improvement
> Components: Streams/Writers
> Affects Versions: 2.11.0
> Reporter: Woden Cafe
> Priority: Minor
> Labels: Commons, io
> Fix For: 2.12.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This change is to make org.apache.commons.io.output.FileWriterWithEncoding
> extend org.apache.commons.io.output.ProxyWriter, to use the ProxyWriter's
> delegate Writer rather than storing the delegate Writer reference within
> FileWriterWithEncoding explicitly.
> This simplifies FileWriterWithEncoding as it no longer needs to override any
> methods from its super class, and no longer needs to store and maintain a
> reference to a delegate Writer explicitly - this is provided by the super
> class already.
> [~kinow] Here is the ticket for the Pull Request.
> https://github.com/apache/commons-io/pull/296
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
