ClaudioConsolmagno opened a new pull request #265: URL: https://github.com/apache/commons-collections/pull/265
See [COLLECTIONS-800](https://issues.apache.org/jira/projects/COLLECTIONS/issues/COLLECTIONS-800) Implementation Notes: - Given that the `Partition` class is a private static class not used by anything else I think it's ok to just use isBalanced as a boolean instead of, say, an enum or having a separate brand new private class for this new method. - Added several comments to clarify the logic, let me know if you think that's too much. - I didn't know how far I could go when refactoring existing tests so I only half changed them for `partition()` method. - Similarly, existing tests all around seem fairly simple but I thought I should have good coverage and test different scenarios for partitionBalanced() hence added the whole `forEach` test cases (I'm a fan of Spock and data driven testing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
