[
https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=676749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676749
]
ASF GitHub Bot logged work on TEXT-211:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 21:35
Start Date: 04/Nov/21 21:35
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r743219933
##########
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##########
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
* @return true if the builders contain the same characters in the same
order
*/
public boolean equals(final TextStringBuilder other) {
- return other != null && Arrays.equals(buffer, other.buffer);
+
+ if(other == null) {
+ return false;
+ }
+ if (this.size != other.size) {
+ return false;
+ }
+ return this.toString().equals(other.toString());
Review comment:
@sebx59 your change makes the code look very similar to the code prior
to the change that added `Arrays.equals` (which I also wouldn't have guessed to
cause a regression here).
Maybe we could just revert it instead?
https://github.com/apache/commons-text/commit/36af8b1884a3ac7bf323a08a7d62e4a290336d2b
And also add a comment in the code so we don't accidentally add the
regression again in the code. WDYT?
##########
File path: src/test/java/org/apache/commons/text/TextStringBuilderTest.java
##########
@@ -1057,15 +1057,24 @@ public void testHashCode() {
final TextStringBuilder sb = new TextStringBuilder();
final int hc1a = sb.hashCode();
final int hc1b = sb.hashCode();
- final int emptyHc = Arrays.hashCode(sb.getBuffer());
- assertEquals(emptyHc, hc1a);
Review comment:
@sebx59 maybe instead of removing the asserts (this :point_up: and
:point_down: ) we could invert them then, if the behavior has changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 676749)
Time Spent: 3h 50m (was: 3h 40m)
> TextStringBuilder equals method changed behaviour from 1.8 to 1.9
> -----------------------------------------------------------------
>
> Key: TEXT-211
> URL: https://issues.apache.org/jira/browse/TEXT-211
> Project: Commons Text
> Issue Type: Bug
> Affects Versions: 1.9
> Reporter: Nikolaos Georgiou
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> We found a regression (or breaking compatibility change) in the
> TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9
>
> The 1.8 version (
> [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915]
> ) would only compare the parts of the buffer that fall within the range
> 0..size.
> The 1.9 version (
> [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855]
> ) compares the entire buffer arrays.
> If a TextStringBuilder has extra capacity in the buffer, comparison fails.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
