[
https://issues.apache.org/jira/browse/NET-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ondřej Fibich updated NET-704:
------------------------------
Description:
NTPUDPClient does not check the originate time of response to match the
transmit time of request. If the transmit time does not matches the originate
time, then the computed time information is invalid. This may happen in case of:
* invalid server implementation,
* on packet lost/duplication if NTPUDPClient instance is used for multiple
requests.
Fix is easy, getTime method could throw IOException in case of no match. Patch:
https://github.com/apache/commons-net/pull/92
was:
NTPUDPClient does not check the originate time of response to match the
transmit time of request. If the transmit time does not matches the originate
time, then the computed time information is invalid. This may happen in case of:
* invalid server implementation,
* on packet lost/duplication if NTPUDPClient instance is used for multiple
requests.
Fix is easy, getTime method could throw IOException in case of no match. I will
prepare a patch.
Labels: easyfix pull-request-available (was: easyfix)
> NTPUDPClient does not check response packet pairing
> ---------------------------------------------------
>
> Key: NET-704
> URL: https://issues.apache.org/jira/browse/NET-704
> Project: Commons Net
> Issue Type: Bug
> Affects Versions: 3.6, 3.8.0
> Reporter: Ondřej Fibich
> Priority: Minor
> Labels: easyfix, pull-request-available
>
> NTPUDPClient does not check the originate time of response to match the
> transmit time of request. If the transmit time does not matches the originate
> time, then the computed time information is invalid. This may happen in case
> of:
> * invalid server implementation,
> * on packet lost/duplication if NTPUDPClient instance is used for multiple
> requests.
> Fix is easy, getTime method could throw IOException in case of no match.
> Patch: https://github.com/apache/commons-net/pull/92
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
