[
https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=679196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679196
]
ASF GitHub Bot logged work on IO-552:
-------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 17:27
Start Date: 09/Nov/21 17:27
Worklog Time Spent: 10m
Work Description: wodencafe commented on a change in pull request #297:
URL: https://github.com/apache/commons-io/pull/297#discussion_r745848559
##########
File path: src/main/java/org/apache/commons/io/FilenameUtils.java
##########
@@ -201,7 +201,7 @@ public static String concat(final String basePath, final
String fullFileNameToAd
if (prefix < 0) {
return null;
}
- if (prefix > 0) {
+ if (prefix > 0 && !fullFileNameToAdd.isEmpty() && '~' !=
(fullFileNameToAdd.charAt(0))) {
Review comment:
@kinow @garydgregory Thank you for the feedback, I will test out the
simplified change tonight and update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679196)
Time Spent: 1h 10m (was: 1h)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -----------------------------------------------------------------------------------------
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
> Reporter: Jochen Tümmers
> Priority: Critical
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
