garydgregory commented on a change in pull request #300:
URL: https://github.com/apache/commons-io/pull/300#discussion_r747768611
##########
File path: src/main/java/org/apache/commons/io/function/IOConsumer.java
##########
@@ -85,13 +150,25 @@
*/
void accept(T t) throws IOException;
+ /**
+ * Returns this {@code IOConsumer} wrapped inside of a {@link Consumer}
+ * that throws {@link UncheckedIOException} for any {@link IOException}s
+ * that are thrown by this {@code IOConsumer}.
+ *
+ * @return a {@code Consumer} that wraps this {@code IOConsumer}.
+ * @since 2.12.0
+ */
+ default Consumer<T> asConsumer() {
+ return wrap(this);
Review comment:
I do not think we need an extra method that just delegates to an
existing one. What is the added value? Am I missing something here?
##########
File path: src/main/java/org/apache/commons/io/IOUtils.java
##########
@@ -394,6 +394,25 @@ public static void close(final Closeable... closeables)
throws IOException {
IOConsumer.forEach(closeables, IOUtils::close);
}
+ /**
+ * Closes the entries in the given {@link Stream} as null-safe operations,
+ * and closes the underlying {@code Stream}.
+ *
+ * @param <T> The element type.
+ * @param closeables The resource(s) to close, may be null.
+ * @throws IOExceptionList if an I/O error occurs.
+ * @since 2.12.0
+ */
+ public static <T extends Closeable> void close(final Stream<T> closeables)
throws IOExceptionList {
+ if (closeables != null) {
+ try {
+ IOConsumer.forEachIndexed(closeables, IOUtils::close);
+ } finally {
+ closeables.close();
Review comment:
This method should not release a resource it did not acquire IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
