garydgregory commented on pull request #826: URL: https://github.com/apache/commons-lang/pull/826#issuecomment-967106336
Full fail list: ``` [ERROR] Medium: Do not catch NullPointerException like in org.apache.commons.lang3.BooleanUtils.and(Boolean[]) [org.apache.commons.lang3.BooleanUtils] At BooleanUtils.java:[line 127] DCN_NULLPOINTER_EXCEPTION [ERROR] Medium: Do not catch NullPointerException like in org.apache.commons.lang3.BooleanUtils.or(Boolean[]) [org.apache.commons.lang3.BooleanUtils] At BooleanUtils.java:[line 306] DCN_NULLPOINTER_EXCEPTION [ERROR] Medium: Do not catch NullPointerException like in org.apache.commons.lang3.BooleanUtils.xor(Boolean[]) [org.apache.commons.lang3.BooleanUtils] At BooleanUtils.java:[line 1127] DCN_NULLPOINTER_EXCEPTION [ERROR] Medium: org.apache.commons.lang3.Streams$ArrayCollector.characteristics() may expose internal representation by returning Streams$ArrayCollector.characteristics [org.apache.commons.lang3.Streams$ArrayCollector] At Streams.java:[line 525] EI_EXPOSE_REP [ERROR] Medium: new org.apache.commons.lang3.builder.DiffBuilder(Object, Object, ToStringStyle, boolean) may expose internal representation by storing an externally mutable object into DiffBuilder.style [org.apache.commons.lang3.builder.DiffBuilder] At DiffBuilder.java:[line 114] EI_EXPOSE_REP2 [ERROR] Medium: org.apache.commons.lang3.builder.DiffResult.getToStringStyle() may expose internal representation by returning DiffResult.style [org.apache.commons.lang3.builder.DiffResult] At DiffResult.java:[line 142] EI_EXPOSE_REP [ERROR] Medium: org.apache.commons.lang3.builder.EqualsBuilder.setBypassReflectionClasses(List) may expose internal representation by storing an externally mutable object into EqualsBuilder.bypassReflectionClasses [org.apache.commons.lang3.builder.EqualsBuilder] At EqualsBuilder.java:[line 275] EI_EXPOSE_REP2 [ERROR] Medium: org.apache.commons.lang3.builder.ToStringBuilder.getStringBuffer() may expose internal representation by returning ToStringBuilder.buffer [org.apache.commons.lang3.builder.ToStringBuilder] At ToStringBuilder.java:[line 1028] EI_EXPOSE_REP [ERROR] Medium: org.apache.commons.lang3.builder.ToStringBuilder.getStyle() may expose internal representation by returning ToStringBuilder.style [org.apache.commons.lang3.builder.ToStringBuilder] At ToStringBuilder.java:[line 1040] EI_EXPOSE_REP [ERROR] Medium: Public static org.apache.commons.lang3.builder.ToStringBuilder.getDefaultStyle() may expose internal representation by returning ToStringBuilder.defaultStyle [org.apache.commons.lang3.builder.ToStringBuilder] At ToStringBuilder.java:[line 117] MS_EXPOSE_REP [ERROR] Medium: org.apache.commons.lang3.exception.DefaultExceptionContext.getContextEntries() may expose internal representation by returning DefaultExceptionContext.contextValues [org.apache.commons.lang3.exception.DefaultExceptionContext] At DefaultExceptionContext.java:[line 111] EI_EXPOSE_REP [ERROR] Medium: Public method org.apache.commons.lang3.reflect.FieldUtils.getDeclaredField(Class, String, boolean) uses reflection to modify a field it gets in its parameter which could increase the accessibility of any class. [org.apache.commons.lang3.reflect.FieldUtils] At FieldUtils.java:[line 179] REFLF_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_FIELD [ERROR] Medium: org.apache.commons.lang3.stream.Streams$ArrayCollector.characteristics() may expose internal representation by returning Streams$ArrayCollector.characteristics [org.apache.commons.lang3.stream.Streams$ArrayCollector] At Streams.java:[line 97] EI_EXPOSE_REP [ERROR] Medium: new org.apache.commons.lang3.text.ExtendedMessageFormat(String, Locale, Map) may expose internal representation by storing an externally mutable object into ExtendedMessageFormat.registry [org.apache.commons.lang3.text.ExtendedMessageFormat] At ExtendedMessageFormat.java:[line 130] EI_EXPOSE_REP2 [ERROR] Medium: org.apache.commons.lang3.time.FastDateParser.getTimeZone() may expose internal representation by returning FastDateParser.timeZone [org.apache.commons.lang3.time.FastDateParser] At FastDateParser.java:[line 280] EI_EXPOSE_REP [ERROR] Medium: org.apache.commons.lang3.time.FastDatePrinter.getTimeZone() may expose internal representation by returning FastDatePrinter.mTimeZone [org.apache.commons.lang3.time.FastDatePrinter] At FastDatePrinter.java:[line 597] EI_EXPOSE_REP [ERROR] Medium: Public static org.apache.commons.lang3.time.FastTimeZone.getGmtTimeZone() may expose internal representation by returning FastTimeZone.GREENWICH [org.apache.commons.lang3.time.FastTimeZone] At FastTimeZone.java:[line 39] MS_EXPOSE_REP[ERROR] Medium: Public static org.apache.commons.lang3.time.FastTimeZone.getGmtTimeZone(String) may expose internal representation by returning FastTimeZone.GREENWICH [org.apache.commons.lang3.time.FastTimeZone, org.apache.commons.lang3.time.FastTimeZone] At FastTimeZone.java:[line 51]Another occurrence at FastTimeZone.java:[line 59] MS_EXPOSE_REP [ERROR] Medium: Comparison of String objects using == or != in org.apache.commons.lang3.time.GmtTimeZone.equals(Object) [org.apache.commons.lang3.time.GmtTimeZone] At GmtTimeZone.java:[line 106] ES_COMPARING_STRINGS_WITH_EQ [ERROR] Medium: Public static org.apache.commons.lang3.tuple.ImmutablePair.nullPair() may expose internal representation by returning ImmutablePair.NULL [org.apache.commons.lang3.tuple.ImmutablePair] At ImmutablePair.java:[line 97] MS_EXPOSE_REP ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
