HubertWo edited a comment on pull request #812: URL: https://github.com/apache/commons-lang/pull/812#issuecomment-971821103
Hi @garydgregory Thank you for your time. I removed Java 17 dependencies. Now everything works agains Java 8. Also it's possible to run benchmarks from command line - exactly the same as described in the official JMH doc. Please find run instructions and example results here: 1. https://github.com/HubertWo/apache-commons-lang-jmh/tree/main/string-joiner 2. https://github.com/HubertWo/apache-commons-lang-jmh/tree/main/string-builder I have also added GitHub Actions which run both benchmarks agains Java 8. Logs from GitHub run: ``` StringJoinerBenchmark.stringJoinerPrimitiveInt thrpt 25 7963210.479 ± 188742.938 ops/s StringBuilderBenchmark.stringBuilderPrimitiveInt thrpt 25 21906622.479 ± 950041.487 ops/s ``` 1. GitHub build logs for StringJoiner benchmark: https://github.com/HubertWo/apache-commons-lang-jmh/runs/4241475267?check_suite_focus=true 2. GitHub build logs for StringBuilder benchmark: https://github.com/HubertWo/apache-commons-lang-jmh/runs/4242012768?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
