sebbASF commented on a change in pull request #95:
URL: https://github.com/apache/commons-net/pull/95#discussion_r780287607
##########
File path:
src/main/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
##########
@@ -243,7 +243,7 @@
+ "(?:(\\d+)\\s+)?" // size, empty for members
+ "(?:(\\S+)\\s+(\\S+)\\s+)?" // date stuff, empty for members
+ "(\\*STMF|\\*DIR|\\*FILE|\\*MEM)\\s+" // *STMF/*DIR/*FILE/*MEM
- + "(?:(\\S+)\\s*)?"; // file name, missing, when CWD is a
*FILE
+ + "(((\\S+)\\s*)+)?"; // file name, missing, when CWD is a
*FILE
Review comment:
I think the RE is more complicated than it needs to be.
Also it does not handle file names which start with a space, if that is
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
