garydgregory edited a comment on pull request #68: URL: https://github.com/apache/commons-validator/pull/68#issuecomment-1011170137
I will review more this by this weekend. In general, why is this required instead of using the parsing built in java.util.UUID? At first glance, I am baffled by the test, the use of side effects for testing make the test unreadable to me, at least. It would be better to follow the style of other tests in this component. Note that Junit has great facilities for paramertized tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
