[ 
https://issues.apache.org/jira/browse/CONFIGURATION-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476148#comment-17476148
 ] 

Patrick Buchheit commented on CONFIGURATION-811:
------------------------------------------------

After looking closer at the source code, I found the problem. 
DefaultDelimiterHandler was actually working as intended. The problem was that 
I was assigning it to the parent CompositeConfiguration rather than the child 
configuration. As a result, the property was never getting split into a list 
when it was initially parsed and stored. Once I assigned the delimiter handler 
to the correct config the problem went away.

 

Marking this as closed.

> ConfigurationConverter Adding Escape Character to Delimited String 
> -------------------------------------------------------------------
>
>                 Key: CONFIGURATION-811
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-811
>             Project: Commons Configuration
>          Issue Type: Bug
>          Components: Interpolation
>    Affects Versions: 2.7
>         Environment: Ubuntu 18.04
> Jdk 1.8
>            Reporter: Patrick Buchheit
>            Priority: Major
>
>  
> I'm working on a project that needs to define and load some properties as 
> delimited lists of strings. I noticed that when I went to load my properties 
> from the configuration, the resulting string has escape characters added 
> before each delimiter. So if my property file has the line 
> *[email protected]@[[email protected]|mailto:[email protected]]*
>  
> then the result of looking up the property will be
> *[email protected]/-foo@[tura.com/[email protected]|mailto:[email protected]]*
>  
> I'm not sure whether this behaviour is intentional or a bug, but it causes 
> problems when trying to use the 'split()' method of 
> AbstractListDelimiterHandler. The escape character causes the delimiter to be 
> treated as a literal, so the string does not get split into parts. Below is a 
> test case demonstrating the behaviour I'm seeing.
>  
>  
> {code:java}
> @Test
> public void testPropertyParsingWithEscape() throws IOException, 
> ConfigurationException
> {
>     File tmpOutput = File.createTempFile("test", ".properties");
>     Writer out = new FileWriter(tmpOutput);
>     out.write("[email protected][email protected][email protected]");
>     out.append("\[email protected]\\[email protected]");
>     out.append("\[email protected]\\\\[email protected]");
>     out.close();
>  
>     Configurations configurations = new Configurations();
>     CompositeConfiguration cc = new CompositeConfiguration();
>     ListDelimiterHandler handler = new DefaultListDelimiterHandler('-');
>     cc.setListDelimiterHandler(handler);
>      
>     cc.addConfiguration(configurations.properties(tmpOutput));
>      
>     Configuration config = cc;
>     final Properties props = ConfigurationConverter.getProperties(config);    
>     
>         String navTo = (String) props.get("mail.to.nav");
>         assertNotNull(navTo);
>         String errorTo = (String) props.get("mail.to.error");
>         assertNotNull(errorTo);
>         String to = (String) props.get("mail.to");
>         assertNotNull(to);
>  
>         List<String> lst1 = (List<String>) handler.split(navTo, true);
>         List<String> lst2 = (List<String>) handler.split(errorTo, true);
>         List<String> lst3 = (List<String>) handler.split(to, true);
>         assertThat(lst1, contains(  
> Arrays.asList("[email protected]","[email protected]","[email protected]")) );
>         assertThat(lst2, contains( 
> Arrays.asList("[email protected]","[email protected]")) );
>         assertThat(lst3, contains( 
> Arrays.asList("[email protected]","[email protected]")) );
>         
> }
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to